Closed tim-silico closed 2 years ago
Hi @tim-silico,
workflow-telemetric-action
needs actions:read
permission to be able to access current workflow job info.
We have applied a fix to prevent action from failing (but logs error message) in case of lack of actions:read
permission.
Could you please try by adding actions:read
permission:
permissions:
actions: read
...
Hi @serkan-ozal
Thanks so much, that's fixed our issue. We're still getting a failure during posting, but it's during the comment posting, which we don't want anyway so I've remove it.
I suspect it's this line: https://github.com/runforesight/workflow-telemetry-action/blob/cd839468e37dd167ab4e5328cb95b0f8689dcf19/src/post.ts#L102 And giving pr write permissions would fix it though.
The Job Summary is exactly what we need, should help debug our slow workflow.
Hi @tim-silico, you can disable PR comment feature by setting comment_on_pr
input to false
as mentioned here: https://github.com/runforesight/workflow-telemetry-action#configuration
In this case (PR comment disabled), you still will be able to see the results in the Github job summary page.
Just FYI, because you want to write a comment into a pull request, you also need pull-requests: write
.
Hi! Can we please update the readme with this very useful information - thank you :)
Thanks for informing @oliversalzburg @sjoedwards.
Added required permission to the description of comment_on_pr
configuration.
Hi,
I've added the step to my workflow with.
And the post step is failing with the error
Error: Resource not accessible by integration
Setup Log:
Post log:
I suspect this is related to permissions as we have restricted them in our workflows, but I can't work out which need to be enabled from a cursory look. We're also using a custom runner, but hopefully that won't cause any issues?
Thanks for developing this, it looks really fantastic.