catdad / canvas-confetti

🎉 performant confetti animation in the browser
https://catdad.github.io/canvas-confetti/
ISC License
10.45k stars 366 forks source link

Confetti doesn't work after obfuscation. #166

Open romua opened 3 years ago

romua commented 3 years ago

2dba049b-ab0e-4504-acab-22196978863e

romua commented 3 years ago

@catdad Could you please help with this?

"javascript-obfuscator": "^2.11.0" used

catdad commented 3 years ago

Hmm... what have you done to investigate so far? I assume you have reason to believe this is an issue with this library and not an issue with the obfuscator?

romua commented 3 years ago

@catdad just high level investigation. Also it is worth mentioned I'm using your wonderful library inside angular-electron app(so all kinds of angular minifications/optimizations are happening). It happens after obfuscation only(so my CI steps: build(works here)> obfuscate(errors here))

claudevervoort commented 2 years ago

I think this may be due to the main function being obfuscated, the code injected may not be able to run in a worker env. Not exactly sure why (like a transpiled function not available?)

https://github.com/catdad/canvas-confetti/blob/master/src/confetti.js#L133

Ambrise commented 9 months ago

I have the same problem...