catdadcode / angular-spinners

A library for easily managing loading spinners in complex Angular2+ applications.
MIT License
140 stars 49 forks source link

Spinner and grunt uglyfy/usemin #12

Closed Stwissel closed 8 years ago

Stwissel commented 8 years ago

As part of my workflow I use a grunt script that deploys to dist by all sorts of steps including concatenation and minification. Spinners work brilliant in the uncompressed version, but won't show up after Grunt has a go. What do I miss in my approach?

Gruntfile.js.txt

catdadcode commented 8 years ago

This is not your fault. I apologize for not getting to this sooner. The reason is that in my naivety I did not include string versions of dependencies in my library because I personally use an angular minifier that does it for me. This being a third party library though means I should probably be doing that so it can be minified safely without the use of that specific utility. I'll update when I have a new version for you shortly.

catdadcode commented 8 years ago

Alright. v3.1.2 is now published and should be minified without issues. Please let me know if you encounter any more problems.