search

catdadcode / poker-engine

32 stars 13 forks source link

Adding package in project with typescript ^4.4.2 fails during build #5

Open seanstern opened 2 years ago

seanstern commented 2 years ago

Sumamry

This package relies on tsc as part of it's build command in package.json.

When this package is added to another project that has a dependency on "typescript": "^4.4.2", the build step fails with:

src/Card.ts(72,3): error TS2717: Subsequent property declarations must have the same type.  Property 'color' must be of type 'CardColor', but here has type 'CardColor'.

Reproduction Steps

  1. Create a new npm package: npm init
  2. Add typescript as a dependency: npm add typescript
  3. Add @chevtek/poker-engine as a dependency: npm add @chevtek/poker-engine

Suggested fix

Update Card.ts such that get color () declaration has return type annotation. That is:

get color (): CardColor {

Additional Notes

I'm going to submit a PR coming your way. Hope this was helpful.