Fix case where invalid response is returned - Githubissues

catduckgnaf / ryobi_gdo

Latest and Greatest Home Assistant Custom Integration for Ryobi GDO

Other

10 stars 6 forks source link

Fix case where invalid response is returned #48

Closed KorvinSzanto closed 8 months ago

KorvinSzanto commented 8 months ago

Breaking change

Proposed change

Fix return type of _process_request
Pin json result to dict to avoid issues like "foo" being returned from the API
Change _process_request to return None if a request fails or a response is invalid.

Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality to an this integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Example entry for `configuration.yaml`:

# Example configuration.yaml

Additional information

This PR fixes or closes issue:
This PR is related to issue: relates to #47

Checklist

[x] The code change is tested and works locally.
[x] There is no commented out code in this PR.
[x] The code has been formatted using Black (black --fast custom_components)

If user exposed functionality or configuration variables are added/changed: