search

caten2 / Tripods2021UA

MIT License
3 stars 5 forks source link

Implement dominion polymorphisms with new `Relation` class #18

Open caten2 opened 10 months ago

caten2 commented 10 months ago

The dominion polymorphisms need to be implemented using the new Relation class. There are a few parts of this:

  1. Right now there is a directory in the project root called mnist. This should probably be changed to a more organized data directory in the project root which can contain the files generated in the course of constructing dominions.
  2. Once the dominion polymorphisms are reimplemented, they should be included in the polymorphism_neighbor_func in src/polymorphisms.py.
  3. It may make sense to include the definition of the actual dominion polymorphisms (as Operations) in src/polymorphisms.py, even if there is still some auxiliary script like src/dominion.py which is used in the construction of the requisite data.
caten2 commented 9 months ago

I'm I'm not mistaken, the latest pull request didn't implement the dominion polymorphisms as a possible option for the polymorphism neighbor function. I'm going to try to do that tomorrow morning before my talk on this.

caten2 commented 9 months ago

I realized that this would've been too much work to do before my talk.