search

catenacyber / perfsprint

Golang linter to use strconv
MIT License
19 stars 2 forks source link

Productionization #1

Closed Antonboom closed 9 months ago

Antonboom commented 9 months ago

Hello!

I made this work as exception, because found your linter useful and hope to see it in the closest release of golangci-lint.

Please, in the next time be more respectful to your code and neighbour contributors. You contribute into the large open source project, but ignores the basic practises of software development.

TLDR:

  1. More simpler project structure.
  2. Fixed installation path (in your version binary will be have name main).
  3. Much more tests.
  4. Much simpler code with much better readability.
  5. Covered some forgotten cases.
  6. Benchmarking for proof of performance improvement.
  7. Makefile, CI, README, etc.

Feel free to review and discuss. Thanks

catenacyber commented 9 months ago

Thank you so much, this looks really good :-) I will post some questions in the code