search

caterinaurban / Typpete

34 stars 6 forks source link

Differences between versions of imp-interpreter and ICemu #41

Closed caterinaurban closed 5 years ago

caterinaurban commented 6 years ago

The differences between the versions of the imp-interpreter and ICemu projects that we use and the originals are very suspicious. For instance, there are calls completely commented out and replaced by pass, and an index in a comprehension is replaced by a number. Are we sure that we are preserving the original functionality of the code? I seriously doubt it. This needs to be fixed and every single change compared to the original version should be meticulously tracked and clearly justified.

caterinaurban commented 6 years ago

I should add that some files from the original versions of the projects have been completely deleted in our versions, again without justification.

caterinaurban commented 5 years ago

Fixed in ca4fec60e74810fb62b53fa4616ee5a8d34158e3.