search

catfan / Medoo

The lightweight PHP database framework to accelerate the development.
https://medoo.in
MIT License
4.84k stars 1.15k forks source link

when select "*" get a php warning #564

Closed luomoxu closed 7 years ago

luomoxu commented 7 years ago

Use medoo 1.4

$database->select("account","*", [ "user_id[>]" => 100 ]);

A PHP Error was encountered

Severity: Warning

Message: Invalid argument supplied for foreach()

Filename: src/Medoo.php

Line Number: 935

catfan commented 7 years ago

Well, fixed it. But we always recommended that don't use * for fetching all columns data. It's no good for the performance and readability.

rakshazi commented 7 years ago

@catfan release bugfix as new version (eg: 1.4.1), please

rakshazi commented 7 years ago

@catfan any update on this?

ghost commented 7 years ago

Medoo v1.4.1 was released - https://github.com/catfan/Medoo/releases

rakshazi commented 7 years ago

@anaggh thank you! Didn't notice it