catfan / Medoo

The lightweight PHP database framework to accelerate the development.
https://medoo.in
MIT License
4.83k stars 1.15k forks source link

[1.4.5] Replace documentation error? #605

Closed patrickvane closed 6 years ago

patrickvane commented 7 years ago

In replace(), it seems the expected input is [valueFrom, valueTo] instead of [valueFrom => valueTo]?

This is weird, because in the documentation (https://medoo.in/api/replace) it says it should be [from => to], but the actual code ignores the keys, and just expects arrays with [from, to] instead.

Is the documentation wrong, or is the code not working as it was intended?

mbrowngold commented 6 years ago

I've noticed this as well.

catfan commented 6 years ago

It's now fixed.