Suggest a change: implode($stack, ';')

catfan / Medoo

The lightweight PHP database framework to accelerate the development.

https://medoo.in

MIT License

4.83k stars 1.15k forks source link

Suggest a change: implode($stack, ';') #841

Closed tianyiw2013 closed 5 years ago

tianyiw2013 commented 5 years ago

implode is used in many places in medoo，The method of use is as follows: implode($stack, ';')、implode($outer_conjunctor . ' ', $stack)、implode($joins, ' AND ') etc.

PHP Manual： implode ( string $glue , array $pieces ) : string

It is suggested to change to the usage specified in the PHP manual.

Medoo.zip

tianyiw2013 commented 5 years ago

see https://www.php.net/manual/en/function.implode.php

tianyiw2013 commented 5 years ago

微信图片_20190604131201 vscode problem hints ↑

catfan commented 5 years ago

Great, that's will be fixed.

tianyiw2013 commented 5 years ago

thanks.good job.