catfan / Medoo

The lightweight PHP database framework to accelerate the development.
https://medoo.in
MIT License
4.84k stars 1.15k forks source link

The documentation about using LIMIT in MSSQL or Oracle is incorrect #929

Closed littlephone closed 3 years ago

littlephone commented 4 years ago

The documentation states that LIMIT clause should be used with GROUP BY. But after I studied the source code, ORDER BY should be used instead

Information

Detail Code // For Oracle and MSSQL database, you also need to use with GROUP by together 'GROUP' => 'location'

Expected output // For Oracle and MSSQL database, you also need to use with ORDER by together 'ORDER' => 'location'

catfan commented 3 years ago

It's doc error.

We also improved this without using ORDER BY for MSSQL dae9fa22cbc38f3d6e3344582226ca2f9f3fa14d.