catgirlfighter / nekopaw

galleries downloader
45 stars 15 forks source link

No pre-checking of download...? #246

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The program doesn't seem to always check in advance for if a file is already 
downloaded... or at least it seems the case on Hentai Foundry. I was 
downloading a gallery for updates, and it was re-downloading each file in full 
before marking ones as already downloaded...

Original issue reported on code.google.com by JarieSui...@gmail.com on 18 Sep 2014 at 5:28

GoogleCodeExporter commented 9 years ago
Grabber unchecking existing files only if it possible.
But script for hentai-foundry is quite old. Basically, you can never know, 
which extansion an original picture uses (until you load a picture's page with 
all links before download, but mostly increases downloading time for about 50%).
But for now I know, how it can be improved.

Original comment by catgirlfighter on 18 Sep 2014 at 10:01

GoogleCodeExporter commented 9 years ago
Hm... could it instead check without looking at the extension? Maybe not 
considered a great idea, but it should end up with the same extension 
normally... (unless a user really loves extension changing)

Original comment by JarieSui...@gmail.com on 18 Sep 2014 at 10:10

GoogleCodeExporter commented 9 years ago
If by any means you will use any name but $fname$, chance of finding the same 
name, but not the same picture is quite high.
Don't worry, I know, how it can be improved, so it will work just fine. I'll do 
it today.

Original comment by catgirlfighter on 19 Sep 2014 at 7:22

GoogleCodeExporter commented 9 years ago
Oh, right, I remember now, why it's impossible.
From time to time you get pictures WITHOUT extension from hentai-foundry, at 
all, and only possible way to get it it's a way described above. That's why you 
can't premake a name for it.
And "ignoring extension" to look for duplicates it's not solution. Search for 
concrete files is dramatically faster than for "possibly" a couple of files by 
format (filename.*), so as more pictures in one folder you keep, as slower 
grabber will work. I.e. it's a bad decision.

Sad, but true.

Original comment by catgirlfighter on 19 Sep 2014 at 10:37

GoogleCodeExporter commented 9 years ago
^_^; Ah, that makes sense. Oh well. It's not a major site of mine anyways (just 
a couple artists that only seem to be there for some reason), so it's not a big 
problem to me. Thanks for looking into it though!

Original comment by JarieSui...@gmail.com on 19 Sep 2014 at 3:19

GoogleCodeExporter commented 9 years ago

Original comment by catgirlfighter on 22 Sep 2014 at 9:38