SPI SS Pin is Incorrectly Bound.

cathalmccabe / pynq-z1_board_files

PYNQ-Z1 board files for Vivado

32 stars 12 forks source link

SPI SS Pin is Incorrectly Bound. #3

Open xusine opened 4 years ago

xusine commented 4 years ago

According to the official XDC file, the SPI SS pin should be mapped to F16, while in this project the port is bound to T16. This may cause unsuccessful data transmission.

rdoursenaud commented 2 years ago

I was about to PR these board files upstream at https://github.com/Digilent/vivado-boards

While preparing to do so, I red the notes from https://github.com/Digilent/vivado-boards/blob/master/README.md According to the notes, the swap was due to https://github.com/Digilent/vivado-boards/issues/5.

Since this board is now retired, I guess it would make sense to follow the master XDC convention.

@cathalmccabe Please let me know what you think.

cathalmccabe commented 2 years ago

That would seem to make sense for this Rev C, however I don't have a board I can test this on right now.

rdoursenaud commented 2 years ago

@cathalmccabe Thanks for replying. I’ll keep using my own fork for now and report back if I encounter any issues. Anybody stumbling upon this issue can also try it from my PR/fork and let us know.