search

catharsis / spotifile

FUSE file system for Spotify
BSD 3-Clause "New" or "Revised" License
144 stars 7 forks source link

Add new option for setting bitrate preset #27

Closed raoulh closed 8 years ago

raoulh commented 8 years ago

bitrate_preset=INT (0=default, 1=96kbps, 2=160kbps, 3=320kbps)

catharsis commented 8 years ago

Oh my, I've totally missed this. I can't figure out why I'm not getting notifications for these things from github. Very sorry.

Anyways, as I'm sure you realise, your proposed change wouldn't have any actual effect on the bitrate, since there's not yet any wrapper implemented for sp_session_preferred_bitrate (https://developer.spotify.com/docs/libspotify/12.1.45/group__session.html#gacd590e095b011af42fb10046117846fe).

To revisit and reevaluate my reasoning from #20, I might have been a bit too quick on the trigger there - I for some reason assumed that setting the bitrate would be effective for the user globally (as in: for all libspotify apps), and not for the current session. After more careful scrutiny, it seems the opposite is true, which would mean that setting the preferred bitrate in the config file is probably the right way to go.

To address your patch more specifically, I feel like it might be more user-friendly to just use the bitrates directly in the config file, instead of enumerating them from 0 through 3. To me bitrate_preset=320kbps is more descriptive than bitrate_preset=3.

raoulh commented 8 years ago

Ok, I messed with the pull request and forgot some patches... shame on me. I will redo another fixed one.