search

catharsis / spotifile

FUSE file system for Spotify
BSD 3-Clause "New" or "Revised" License
144 stars 7 forks source link

Add new option for setting bitrate preset #35

Closed raoulh closed 8 years ago

raoulh commented 8 years ago

New pull request for adding bitrate option with last fix

catharsis commented 8 years ago

Nice - thanks! Like I just commented in #28 I think calling spotify_bitrate_preset function without a valid bitrate should be treated as an error (g_return_if_fail) and check if it's null before calling instead.

I think you could squash these commits though. Or I could do it myself if you prefer.

Also, why is b705a77 recommitted - it looks like a merge error, especially since 16bd413 reverts its changes. Again, I'll fix it up myself if you prefer, just let me know.

raoulh commented 8 years ago

Ah damn... the recommit thing was probably due to the rebase of my branch to your master. I should have squashed the commit prior doing the rebase.

If you have time, you can do it. I may not have time to rework on that too soon...

catharsis commented 8 years ago

I merged b3a37aff5 and did some fixup in 7ea2633.

Thanks a lot @raoulh!