Issue with a complex data structure

cathei / BakingSheet

Easy datasheet management for C# and Unity. Supports Excel, Google Sheet, JSON and CSV format.

MIT License

346 stars 34 forks source link

Issue with a complex data structure #34

Closed laicasaane closed 1 year ago

laicasaane commented 1 year ago

Hi, could you tell any problem with this data? It doesn't work however I try. The exported file Skills.json is always empty. https://github.com/laicasaane/BakingSheet/commit/330e426e01594451bb16818520faa779f57e03be

cathei commented 1 year ago

Seems like your xlsx contains empty row - which BakingSheet consider as end of the file. (I have not found a better way to detect yet.)

laicasaane commented 1 year ago

I've implemented something called empty row streak threshold to allow bypassing a number of empty rows before considering it's the end of file. Using this implementation for a while makes me forget that the original BakingSheet doesn't have that mechanism.

https://github.com/Zitga-Tech/ZBase.Foundation.Data/blob/e79ff18bad5e3892a38f2155acfdd9ce788b46a8/Packages/ZBase.Foundation.Data/Data.Authoring/Converters/DatabaseRawSheetImporter.cs#L27C42-L27C42

cathei commented 1 year ago

I might adopt something like that in future.