search

catherine11 / google-refine

Automatically exported from code.google.com/p/google-refine
Other
0 stars 0 forks source link

Running Google Refine under a Java server named context #576

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Java EE applications usually run under a context name. Trying to do so with 
Google Refine, I found it's currently impossible due the invocation to several 
resources point to the root ('/') hardcoded in the Javascript code.

Please, find attached a patch that, I guess, solves the issue, allowing to run 
Google Refine under any sub-path, keeping at the same time full compatibility 
for running it at the root one as usual.

Could this patch cause any issue on third-party extension?

I'm completely sure than this patch could be improved by taking the 
'butterfly.url' configuration, but I didn't find how to do it at its 
documentation .

Original issue reported on code.google.com by sergio@wikier.org on 14 May 2012 at 12:10

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for the patch.  We'll try to get it reviewed and applied.

Original comment by tfmorris on 14 May 2012 at 7:24

GoogleCodeExporter commented 9 years ago 
Well, actually I'm not sure if this patch applies only under Java containers, 
or could be also useful under other deployment environments, such as inverse 
http proxies.

In case it could help, I also point a related issue detected in an extension: 
https://github.com/fadmaa/grefine-rdf-extension/pull/51#issuecomment-5691585

Original comment by sergio@wikier.org on 14 May 2012 at 8:10

GoogleCodeExporter commented 9 years ago 
Here also another patch for solving some non null-save operations.

Original comment by sergio@wikier.org on 18 May 2012 at 7:30

Attachments:

GoogleCodeExporter commented 9 years ago 
Attached a clean version of the first patch (I was used some fake paths which 
may introduce issues applying it).

Original comment by sergio@wikier.org on 28 Jun 2012 at 2:48

Attachments:

GoogleCodeExporter commented 9 years ago 
Attached another small patch for fixing the core module's controller.

Original comment by sergio@wikier.org on 28 Jun 2012 at 2:51

Attachments:

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I'm thinking that all invocations to "../command/foo" actually must be to  
"command/foo"

Original comment by sergio@wikier.org on 29 Jun 2012 at 10:18

GoogleCodeExporter commented 9 years ago 
Do you plan to take care of this issue someday?

Attached the last version of the patch including all changes working, that 
could be retrieved from the mercurial where we worked on: 
http://bitbucket.org/wikier/google-refine 

I don't want to convert such temporal repository in a fork of the project, but 
with latest changes it starts to be quite hard to keep it synchronized with 
upstream.

Original comment by sergio@wikier.org on 31 Aug 2012 at 7:50

Attachments:

GoogleCodeExporter commented 9 years ago 
I'm a little bit concerned about testing, but I'll see if we can get this 
included in the next release.

Original comment by tfmorris on 19 Sep 2012 at 11:24

GoogleCodeExporter commented 9 years ago 
Cool! I can support you on testing if needed.

Original comment by sergio@wikier.org on 20 Sep 2012 at 6:12

GoogleCodeExporter commented 9 years ago

Original comment by tfmorris on 12 Oct 2012 at 7:17

GoogleCodeExporter commented 9 years ago 
OK, the patch has been applied in r2584. It was missing some /command 
references in the Freebase extension, clustering, etc.  Hopefully I caught them 
all.  The majority of the risk of things not working is when you're not running 
at the root, so normal operation should be unaffected.  Let us know if you find 
any references which were missed.  Although you mentioned changing "../command" 
to just "command" I still found "../command" references so those were changed 
before committing.

The patch also included a couple of unrelated things like the temporary 
directory fix.  For future reference, please keep each patch focused on a 
single issue.

The file main/webapp/WEB-INF/web.xml had some changes that I didn't include:
- I restored the DTD reference
- I didn't include the refine.data definition (but left it there commented out 
for now)
- I restored some of the Jetty parameters that had been commented out

Original comment by tfmorris on 13 Oct 2012 at 5:50

GoogleCodeExporter commented 9 years ago 
Yes, some stuff I don really use it (some extensions, for instance) were not 
included on the original patch. Beside our changesets maybe included more stuff 
that strictly this concrete issue, sorry about that.

During the week I'd try to check that everything is working, both at the root 
context and a named one.

Original comment by sergio@wikier.org on 15 Oct 2012 at 11:03