search

catherinezucker / radfil

Building Radial Density Profiles for Interstellar Filaments
GNU General Public License v3.0
14 stars 8 forks source link

What happened to the "local mask width" attribute returned by build profile? #4

Closed catherinezucker closed 7 years ago

catherinezucker commented 7 years ago

Line 324 in radfil_class.py """ distpc: numpy.ndarray A numpy array containing the physical size of each "local width" cut. Can take the mean/median to determine representative width of the filament mask """

It is listed as an attribute accessible after build_profile, but doesn't exist anymore, and I use it in my current large-scale filament analysis. I also can't find it embedded in any of the other attributes. If it's not there anymore, I think we need to add it back in, as it is a critical width determination when the radial profile fitting is not possible. Do you think you might be able to do this @hopehhchen , since I'm still working my way through your code revision and not familiar with all the new variable names you've chosen yet? Thanks :).

hopehhchen commented 7 years ago

Makes sense. I'll do it.

catherinezucker commented 7 years ago

Thanks so much!!

On Wed, Aug 2, 2017 at 10:13 PM, Hope Chen notifications@github.com wrote:

Makes sense. I'll do it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/catherinezucker/radfil/issues/4#issuecomment-319848586, or mute the thread https://github.com/notifications/unsubscribe-auth/ARfXSfCpWUo2xJeoGr9sIYCLuRDUDIxPks5sUSysgaJpZM4Or3Uf .

hopehhchen commented 7 years ago

Done. See 1eba7c120861156581b91fbef46f696e0a79de23. The "local mask width" is stored under the key mask_width in dictionary_cuts. This is only done when cutting = True.