cathiele / homeassistant-goecharger

Home Assistant custom_component for controlling the go-eCharger EV-Charger
MIT License
89 stars 29 forks source link

Integration is using deprecated `DEVICE_CLASS_*` constants #74

Closed frenck closed 1 year ago

frenck commented 1 year ago

Describe the bug

This custom integration uses deprecated DEVICE_CLASS_* constants in its codebase.

The DEVICE_CLASS_* constants have been deprecated and replaced in Home Assistant Core 2021.12 (over a year ago). I would highly suggest updating/migrating this integration to the new enums.

For example, for the device classes supported by the sensor platform, there is now a SensorDeviceClass enum. So if a sensor previously used the DEVICE_CLASS_ENERGY constant, it should now use SensorDeviceClass.ENERGY. Other platforms (like binary_sensor, and number) provide similar enumerations for their supported device classes.

The migration thus only consists of replacing constants with an enumeration member and is, therefore, very low impact and should be fairly straightforward.

If I can help resolve any questions regarding this change or migration, feel free to ask or respond to this issue. I'm happy to help!

Kindest regards,

../Frenck

To Reproduce

n/a

Expected behavior

n/a

Screenshots

n/a

Versions (please complete the following information):

Additional context

n/a

cathiele commented 1 year ago

Thank your for pointing this out! I will do the change but at the moment I have no direct access to the charger until February for testing. So it may take some time.

Zoltan-Fehervari commented 1 year ago

It would be nice if you can change the sensor types for non-numeric values to diagnostic. For example car_status, adapter, charger_access and charter_err. At the moment, I don't have a valid history of these sensors: image

I have a proper history in other integration: image

frenck commented 1 year ago

@Zoltan-Fehervari, I fail to see how that is related to this issue I raised?

../Frenck