fix for "set current ampere" feature in Firmware Version 042.0

cathiele / homeassistant-goecharger

Home Assistant custom_component for controlling the go-eCharger EV-Charger

MIT License

89 stars 29 forks source link

fix for "set current ampere" feature in Firmware Version 042.0 #91

Open chises opened 10 months ago

chises commented 10 months ago

Fix for #84 changed setTmpMaxCurrent to setMaxCurrent. Bases on API documentation this is fine: the https://github.com/goecharger/go-eCharger-API-v1/blob/master/go-eCharger%20API%20v1%20DE.md

julian-eggers commented 5 months ago

@cathiele Can you please merge this fix and release a new version?

Heavendenied81 commented 5 months ago

PLease do not Merge this. Yes, it works for newer Fimrwares and also older Firmwares (below 0.40), but it will write the current to amp instead amx and that will use the flash memory much more! This should be fixed by Go-E in the Firmware so that amx can be used for newer Fimrwares as well.