cathive / concourse-chartmuseum-resource

interacts with a Chart Museum instance or Harbor (Kubernetes Helm Charts storage)
Apache License 2.0
14 stars 9 forks source link

Support Harbor API (and bump to v0.7.1) #9

Closed funkypenguin closed 5 years ago

funkypenguin commented 5 years ago

Hey - I spent some time after getting stuck on issue #8 digging into the differences between the ChartMuseum API and the Harbor API. This PR adds an optional harbor_api value to the source, which plays nicer with Harbor. If the value isn't added, nothing changes, and the resource would still (I expect) work with ChartMuseum.

It's working nicely with my Harbor install, but I haven't validated it against ChartMuseum.

Cheers! D

headcr4sh commented 5 years ago

Wow. First of all: thanks for the PR. I assume Harbor is the widely used on-premises Helm Chart Repo and therefore the value added is really appreciated!