search

cathive / concourse-sonarqube-resource

performs SonarQube analyses and checks quality gates https://concourse-ci.org/ https://sonarqube.org/
Apache License 2.0
46 stars 49 forks source link

New `additional_properties_file` out-param #28

Closed zerok closed 5 years ago

zerok commented 5 years ago

This should help in situations where you have to set dynamic properties for the scanner in a previous task. All these properties should then be written to a single file which can then be used here.

headcr4sh commented 5 years ago

Great idea.

But... ...parsing a .properties file is not quite as simple as splitting every line at the = character, though. The encoding of properties files has to be latin-1 and there are a bunch of rules concerning max-line length and how to escape certain special chars. This is why I have added a AWK script that should deal with all the oddities of proper .properties file parsing.

The bash function read_properties already wraps the needed parsing functionality. Do you think it would be possible to use this function instead?

zerok commented 5 years ago

Good point. I tried that before going with the simple splitter but I will try again in the next couple of days :)

zerok commented 5 years ago

Done :)