search

cathive / concourse-sonarqube-resource

performs SonarQube analyses and checks quality gates https://concourse-ci.org/ https://sonarqube.org/
Apache License 2.0
46 stars 49 forks source link

Add PR decoration support #47

Closed fftorres closed 4 years ago

fftorres commented 4 years ago

We are using SonarCloud and, in order to decorate our PRs, we missed this feature in the resource. This PRs aims to add support for PR decoration if the user is using SonarCloud and probably will work with Developer Edition. We could use the resource as is but would be very trick to create custom sonar-project.properties file containing the branch name and PR

headcr4sh commented 4 years ago

We use shellcheck to make sure that the shell scripts are a bit more robust. That's why the Travis CI build is currently failing. Can you try to change the things that shellcheck complains about?

(Shellcheck can also be installed locally and integrates into some editors and IDEs quite nicely)

fftorres commented 4 years ago

Thanks for accepting the PR @headcr4sh . I fixed the shellcheck complains and it's good to merge now!

headcr4sh commented 4 years ago

Thank you! Merging now... :-)