search

cathive / concourse-sonarqube-resource

performs SonarQube analyses and checks quality gates https://concourse-ci.org/ https://sonarqube.org/
Apache License 2.0
46 stars 50 forks source link

out: Fixing the error on CLI when maven settings file doesn't exist #68

Closed Seraf closed 3 years ago

Seraf commented 3 years ago

Hello,

The current version was broken on CLI as the resource was looking for a maven settings file. This commit is fixing it by adding an IF condition before trying to guess its path.

I also found a problem with PR identification in the decorate_pr attribute. At the top of the resource, there is a cd ${project_path} Then all conditions are checking for ${project_path}/.git. The problem is that with the cd occurring above, it will never find this project path as we are already in.

There were three options: 1/ use the absolute path in the configuration of the resource 2/ remove the cd project_path at the top of the resource 3/ prefix the project path with the absolute path to make all conditions passing correctly

I went with the third option that was the less modifying/destroying the logic of the resource

If you want to give a try (testing that the fix for maven doesn't impact maven too), here is my patched docker image

Closes #66

headcr4sh commented 3 years ago

Thanks for the PR, @Seraf ! I have addded one question to the PR which I'd like to clarify before merging your changes.

Seraf commented 3 years ago

Thanks, I replaced the hardcoded path with your suggestion. Using $source/ works well, I updated my docker image if you want to give it a try :+1: