search

cathive / concourse-sonarqube-resource

performs SonarQube analyses and checks quality gates https://concourse-ci.org/ https://sonarqube.org/
Apache License 2.0
46 stars 49 forks source link

Update typescript version in Dockerfile #87

Closed JR40159 closed 1 year ago

holgerstolzenberg commented 1 year ago

We are struggling with setting up the build secrets properly at the moment.

@JR40159 Could you please rebase your PR with the most recent main branch!?

JR40159 commented 1 year ago

We are struggling with setting up the build secrets properly at the moment.

@JR40159 Could you please rebase your PR with the most recent main branch!?

Updated the PR with latest on main :)

holgerstolzenberg commented 1 year ago

@JR40159 did you already receive a maintainer invitation from @headcr4sh ?

holgerstolzenberg commented 1 year ago

So it looks like the PR is not able to pick up the Github actions secrets by reason: https://stackoverflow.com/questions/73866908/github-actions-main-repository-secret-not-picked-up-from-pull-request-build

In order to not hinder the PR any more I am going to merge it. We will have to look up deeper into https://securitylab.github.com/research/github-actions-preventing-pwn-requests/.