search

cathive / concourse-sonarqube-resource

performs SonarQube analyses and checks quality gates https://concourse-ci.org/ https://sonarqube.org/
Apache License 2.0
46 stars 50 forks source link

ignore_all_error parameter type is not a bool #89

Closed mrdimfox closed 10 months ago

mrdimfox commented 1 year ago

Version: v0.14.2

README states that quality_gate.ignore_all_error has type bool. But actually, it is compared against ERROR string.

https://github.com/cathive/concourse-sonarqube-resource/blob/709aa2753f4c603fb52ef03e190b6d8795b008c0/assets/common.sh#L149

Probably a copy-pasta bug from line 147

https://github.com/cathive/concourse-sonarqube-resource/blob/709aa2753f4c603fb52ef03e190b6d8795b008c0/assets/common.sh#L147

holgerstolzenberg commented 10 months ago

Can you give it a try after the latest build has been pushed: https://github.com/cathive/concourse-sonarqube-resource/actions/runs/6665853754