cathoderaydude / Babel

A simple translation tool for on-screen text using Google Cloud Vision and Translate. Intended for translating emulated videogames and similar things.
MIT License
2 stars 0 forks source link

Figure out what's going on with settings #31

Open cathoderaydude opened 4 years ago

cathoderaydude commented 4 years ago

It's possible that it was just a bug, but I was unable to get the Settings object to behave sensibly when I had it attached to the AutoOCR toggle.

I had it rigged up so when you clicked the toggle, it changed and immediately saved the setting. Sometimes it would take several clicks to make the setting take, and sometimes I would apply it and then go into the Settings panel - where the setting is duplicated - and it wouldn't match the toolbar setting, and vice-versa. This may have had something to do with the behavior of the LoadSettings method.

Either way, I decided to switch this back to a global variable that defaults to false, since I don't think this really is a setting the user wants persisted, but it makes me worry about the behavior of the Settings object.