search

catholicon / OfflineQR

Offline QR code generator
https://addons.mozilla.org/en-US/firefox/addon/offlineQR
Mozilla Public License 2.0
23 stars 11 forks source link

Not compatible with e10s #27

Open rugk opened 8 years ago

rugk commented 8 years ago

Is this add-on compatible with Electrolysis (e10s)? Electrolysis is the new architecture of Firefox and Mozilla already rolls out some stable Firefox versions with e10s enabled.

More information:

According to ACR this add-on is not compatible with e10s.

catholicon commented 8 years ago

Thanks for the report @rugk. I hadn't explicitly checked ACR. The add-on, btw, has been working fine on my latest release build installation. I'd check why ACR doesn't think so and update if required.

rugk commented 8 years ago

You have to update your manifest file if you want ACR to say "Add-on is compatible with e10s".

catholicon commented 8 years ago

So, finally I got around to check e10s out. And, it turns out that we use sdk/selection API (to show QR for selection) which doesn't quite work yet as mentioned here :(. I've cc'ed myself to this issue but I think migrating to web-extension might be a better long term solution.

rugk commented 6 years ago

BTW I've created a WebExtension QR code add-on for modern Firefox versions, and it soon also supports generating QR codes from a selection. See https://github.com/catholicon/OfflineQR/issues/29#issuecomment-382406858.

catholicon commented 6 years ago

@rugk, since I'm clearly unable to maintain my extension, I'd be happy to put out a link for you extension in this repo (amo page for my addon isn't usable anyway now). Would that be okay?

rugk commented 6 years ago

Sure, that would be glad. :smiley: