search

cathugger / mkp224o

vanity address generator for tor onion v3 (ed25519) hidden services
Creative Commons Zero v1.0 Universal
1.27k stars 150 forks source link

Docker support #99

Closed SophiaH67 closed 1 year ago

SophiaH67 commented 1 year ago

This PR adds a Dockerfile with a ci file that automatically builds and publishes the docker image to the github registry.

To make the CI work, a small thing does need to be done in the repository settings, which is under the Actions / General tab. The setting is called Workflow permissions, and it needs to be set to the top checkbox (Read and write permissions).

cathugger commented 1 year ago

thank you. i'll get back to this later, need to decide what to do with current contrib/docker/Dockerfile, and seems that stuff in github workflow yaml could get some version bumps / cleanups too. otherwise seems handy enough, & trust / supply chain security wise should probably be fine if we trust github/microsoft to host code without sabotaging it in the first place.

vansergen commented 1 year ago

@cathugger What do you think about adding multi-platform images? Here is an example.

cathugger commented 1 year ago

I was thinking that they could come handy, but idk if there's much demand. Maybe aarch64, perhaps ppc64le too, but I don't think anything else is really worth supporting.