Leftovers and Browser Testing

cathywilkie / ecommerce-pattern-library

A term-long project redesigning an ecommerce website focusing on making a pattern library.

https://sad-sinoussi-86a121.netlify.com/pattern-library

0 stars 0 forks source link

Leftovers and Browser Testing #3

Open cathywilkie opened 4 years ago

cathywilkie commented 4 years ago

Hi Thomas! I finished the leftovers and Browser testing (checking all the boxes!) However, I tried to start creating my starter product list page, and the 'Preparing product data', and I feel like I broke everything... I also realized my icons and Logo colour would reset (to black instead of white) everytime I close and open Jekyll in the Terminal. Any idea why or how I can fix that?

@thomasjbradley

thomasjbradley commented 4 years ago

Product page: seems to be a typo in your _config.yml The indentation on these lines is all wonky. https://github.com/cathywilkie/ecommerce-pattern-library/blob/master/_config.yml#L26-L33

Paste this instead:

collections:
  products:
    output: true
defaults:
  - scope:
      path: _products
    values:
      layout: product

Image resetting: are you making adjustments inside the _site folder? That folder is deleted and recreated by Jekyll regularly.

cathywilkie commented 4 years ago

Hi Thomas, I fixed the colour issue! It was indeed the _site folder... I also finished those two quizzes:

@thomasjbradley

cathywilkie commented 4 years ago

My product Data is also working! I fixed the indentations and realized I wasn't using the good url to view it in my browser, haha...

I also fixed my broken cards, which had anchor tags from a btn... well, inside another anchor tag from my cards.

@thomasjbradley