search

catkin / catkin_tools

Command line tools for working with catkin
Apache License 2.0
163 stars 146 forks source link

unrecognized arguments: --no-deps --no-color #689

Closed arturmiller closed 3 years ago

arturmiller commented 3 years ago

System Info

I installed the most recent master branch with:

pip3 install -U "git+https://github.com/catkin/catkin_tools.git#egg=catkin_tools"

Expected Behavior

When running tests with catkin_tools, it should be able to find the arguments "--no-deps" and "--no-color".

Actual Behavior

When running the tests with catkin_tools, the arguments "--no-deps" and "--no-color" are not found anymore. I get following error message:

catkin: error: unrecognized arguments: --no-deps --no-color

Steps to Reproduce the Issue

Just run following command with any package:

catkin run_tests <any_package> --no-deps --no-color

I saw, that recently there was a bigger change regarding running tests with catkin_tools. I think this might be a regression because of this change. Maybe it is now intended to use these arguments in a different way, but the documentation doesn't say anything about it.

arturmiller commented 3 years ago

I saw that in the PR #676 in fact the documentation has been updated. It looks like, that it did not propagate to catkin-tools.readthedocs.io, yet. The new documentation does not mention this arguments anymore. Maybe "--no-deps" is now default? I found a workaround with intended behavior and similar (same?) output:

catkin build <any_package> --no-deps --no-color --interleave-output --catkin-make-args run_tests
timonegk commented 3 years ago

To replicate the old behavior, you can indeed use the command that you found. However, I would recommend to use the new catkin test verb that can be used like this: catkin test <any_package> --interleave-output. It runs the same tests as run_tests but has a more useful output. --no-deps became the default for catkin test. I added the --no-deps and --no-color arguments for backwards compatibility in #693, thank you for pointing out the regression.