search

catkin / catkin_tools

Command line tools for working with catkin
Apache License 2.0
163 stars 146 forks source link

catkin build crash on zsh #708

Open acz-a opened 2 years ago

acz-a commented 2 years ago

When running 'catkin build' on macos, the commands (resultspace.py; line 117):

command = ' '.join([
        cmd_quote(setup_file_path),
        shell_path,
        '-c',
        '"env --null"',
    ])

causes build crash due to the keyword --null not existing on zsh.. suggest you remove it while using zsh terminal or use a broader exception than: IOError on the try...except clause. Thanks!

mgrrx commented 2 years ago

Affects MacOS since env does not have this argument on MacOS:

`ENV(1) BSD General Commands Manual ENV(1)

NAME env -- set environment and execute command, or print environment

SYNOPSIS env [-iv] [-P altpath] [-S string] [-u name] [name=value ...] [utility [argument ...]]`

Tobias-Fischer commented 2 years ago

Is there any news on this? I just ran into this issue.

timonegk commented 2 years ago

I cannot reproduce the issue on my system (also using zsh). For me, env is a program located in /usr/bin/env. It does not change based on the used shell. So, which operating system are you on? What is the output of which env in your shell? And which version of the shell are you using?

Tobias-Fischer commented 2 years ago

I fixed it with conda install coreutils on my (osx) machine. The env program shipped with that supports the --null argument, while the one shipped with osx doesn't.