search

catkin / catkin_tools

Command line tools for working with catkin
Apache License 2.0
163 stars 146 forks source link

Correct usage check of build/skiplist #716

Closed MatthijsBurgh closed 2 years ago

MatthijsBurgh commented 2 years ago

In case an user uses --no-buildlist or --no-skiplist the arguments are set to an empty list, this resolves to False in the old situation. While it should check for it not being set at all, which is equal to None.

P.S. these assert_in_config checks need to be updated to buildlist/skiplist for the breaking release.

MatthijsBurgh commented 2 years ago

See the GH action run on my repo for it failing on adding the test: https://github.com/MatthijsBurgh/catkin_tools/actions/runs/2003199792 But it succeeding when fixing the code: https://github.com/MatthijsBurgh/catkin_tools/actions/runs/2003201973 (This should of course be the same as the GH actions PR run on this repo)

timonegk commented 2 years ago

Thank you!

MatthijsBurgh commented 2 years ago

@timonegk could you please create a new release including this fix?

timonegk commented 2 years ago

Yes, it is released now as 0.8.5 and published to pypi. @wjwwood could you release it to the package archives, please?

wjwwood commented 2 years ago

Should be done. 👍