search

catkira / py3gpp

A Python package for 5G-NR simulations
GNU Affero General Public License v3.0
97 stars 17 forks source link

[feature] implement nrCodeBlockSegmentLDPC() and nrCodeBlockDesegmentLDPC() #39

Closed catkira closed 1 year ago

catkira commented 1 year ago

@vborchsh can You add a Matlab test to this? Matlab uses -1 for filled bits, I am currently using 0. Do You think we should also use -1?

vborchsh commented 1 year ago

Yes, I put this in my todo list :)

I think 0 is fine. Let's keep only external interfaces the same like in MATLAB. Code inside might be significantly different.

catkira commented 1 year ago

but that's an external interface, I will just change the fill bits to -1.