catkira / py3gpp

A Python package for 5G-NR simulations
GNU Affero General Public License v3.0
97 stars 17 forks source link

nrPathLoss() rural macro path loss model result have ~+/-0.5db inaccuracy #57

Closed zulfadlizainal closed 1 year ago

zulfadlizainal commented 1 year ago

image

I have sometime this afternoon, i will review again calculation from TR 38.901.

catkira commented 1 year ago

Thanks! Can you also add a test in the tests/matlab folder that compares it directly with matlab?

zulfadlizainal commented 1 year ago

Close this issue with above pr.

Fix some math syntax and get similar result as matlab docs. image

catkira commented 1 year ago

can you also add a hardcoded test for this?

catkira commented 1 year ago

I did that already.

zulfadlizainal commented 1 year ago

thanks for supporting :)