search

catnekaise / cognito-idpool-auth

Authenticate with Amazon Cognito Identity from GitHub Actions.
https://catnekaise.github.io
MIT License
3 stars 7 forks source link

For basic flow, output `cognito_identity_oidc_access_token` not populated #6

Open kubevalet opened 3 months ago

kubevalet commented 3 months ago

In the outputs section, I see:

  cognito_identity_oidc_access_token:
    description: "Cognito Identity OIDC Access Token"
    value: ${{ steps.output.outputs.oidc_token }}

So it's expecting to be populated from oidc_token ...

But, in the output step, I see:

 echo "cognito_oidc_access_token=$oidcAccessToken" >> "$GITHUB_OUTPUT"

shouldn't this be oidc_token?

fwiw ~ I reverted back to using catnekaise/cognito-idpool-basic-auth@alpha and am able to access the token via:

${{ steps.web_id_token.outputs.cognito_identity_oidc_access_token }}
djonser commented 3 months ago

@kubevalet you are correct, I referenced the incorrect variable to output the OIDC token. Nice to see someone uses the feature.

Do you want to open a PR or should I go ahead and fix this?