search

catppuccin / Kvantum

🧚 Soothing pastel theme for Kvantum
MIT License
84 stars 8 forks source link

Focused buttons don't get highlighted #2

Closed code-IM-perfect closed 3 weeks ago

code-IM-perfect commented 2 years ago

I'm using macchito blue and the keyboard focused buttons don't get highlighted as you'd expect. if it's something that'd take time, just point me in the right category that controls it (I suspect its ItemView)

There's a ss of the issue Screenshot_86

here quit is in focus and I can change the focus via arrows but there's no visual indicator.

mouse focus works as expected Screenshot_87

elkrien commented 2 years ago

It's with the focus section but to be honest I have no luck to correct it. Will need more time to figure it out.

code-IM-perfect commented 1 year ago

@elkrien I figured it out, all you need is combo_focus_rect=true in the general section

also I needed to change the width and color of the focus lines to make them more visible. image

code-IM-perfect commented 8 months ago

@elkrien I am willing to fix this...but how did you generate these? like do I have to change stuff on all of the flavors manually? or is there a better approach?

stenehall commented 1 month ago

I'm not sure what the problem is. But assuming that combo_focus_rect is needed this would solve it https://github.com/catppuccin/Kvantum/compare/main...stenehall:add-combo-focus-rect?expand=1

I'm not sure how to test this do, since I've not seen the actual problem.

@code-IM-perfect could you test the updated theme and confirm if this works or not? Before I open a PR.

code-IM-perfect commented 1 month ago

@stenehall actually the entry isn't enough...I also needed to change the focus element in the svg file that I have shown in the screenshot

stenehall commented 1 month ago

@stenehall actually the entry isn't enough...I also needed to change the focus element in the svg file that I have shown in the screenshot

Right. I clearly failed to read your entire message. If you still have your changes I can generate the theme for it. If you don't prefer to create a PR yourself?

code-IM-perfect commented 3 weeks ago

@stenehall Sorry was short on time for a while, I made a PR that fixes it

Thanks for the offer!