catppuccin / bat

🦇️ Soothing pastel theme for Bat
MIT License
273 stars 8 forks source link

Line highlight color makes it near impossible to read text #12

Closed josh-nz closed 4 months ago

josh-nz commented 4 months ago

A line highlight colour was adjusted in #2 with commit https://github.com/catppuccin/bat/commit/ba4d16880d63e656acced2b7d4e034e4a93f74b1

This set the lineHighlight to #585b70 in the Mocha theme, for example.

The current lineHightlight in this theme is #cdd6f412 which makes the text nearly impossible to read.

A similar issue affects the other Catppuccin bat themes here.

I'm not sure why this this colour was changed, but perhaps revert it back?

Screen Shot 2024-04-04 at 19 45 33
josh-nz commented 4 months ago

Ok, the older lineHighlight has readability issues with commented lines, so perhaps a new highlight color needs to be found:

Screen Shot 2024-04-04 at 19 51 57
lpnh commented 4 months ago

I was about to report the same issue. Changing to Surface0 and keeping the same alpha value solved it for me. See: https://github.com/lpnh/dotfiles/commit/0173de7dcacabc6d94e828d58c281dc10aec7593