Open 42Willow opened 3 months ago
justfile
for ease of use with Whiskers (see https://github.com/catppuccin/fr33zmenu/blob/main/justfile for an example, just change the template filename).Good idea
/docs
exampleHey :wave: Sorry for the wait on this one.
I have a couple questions about the port/codebase:
It would be a lot nicer if the code for the example site was in a subdirectory instead of being at the root level and inside /docs
.
Could you try to restructure the repository as outlined below?
.
βββ assets
βΒ Β βββ frappe.webp
βΒ Β βββ latte.webp
βΒ Β βββ macchiato.webp
βΒ Β βββ mocha.webp
βΒ Β βββ preview.webp
βββ example
βΒ Β βββ bun.lockb
βΒ Β βββ package.json (for demo site)
βΒ Β βββ src
βΒ Β βΒ Β βββ index.md
βΒ Β βββ tsconfig.json
βββ LICENSE
βββ package.json (for publishing to npm)
βββ README.md
βββ theme
βΒ Β βββ frappe.css
βΒ Β βββ index.js
βΒ Β βββ macchiato.css
βΒ Β βββ mocha.css
βββ vitepress.tera
No. 4 is more of a refactoring exercise that can be carried out at later point but I'd be happy to merge if No. 1 -> No. 3 were explained / implemented.
Thanks!
Can we add a section on the FAQ on why Latte isn't included? I'm assuming this is because of a technical limitation of some sort? I can't think of any reason why Latte wouldn't be included if it is technically feasible. I'm even more confused by the fact that there is a Latte preview image but no CSS file for it.
Below the usage section there is a note that says:
Frappe is included in all flavors as the light mode variant.
I believe that is a typo and is meant to say latte.
Thanks for the detailed feedback and advice :)
I believe that is a typo and is meant to say latte. Oops sorry thatβs a typo.
I am currently on holidays so I will get back to the feedback and finishing the port soon.
I have no idea what I'm doing so could someone please take a look at https://github.com/42Willow/vitepress? I've tried to take on the feedback but I have limited experience with this stuff.
Using css to override the accent colour doesn't seem like the most elegant way to do it :thinking: https://github.com/42Willow/vitepress/tree/main/example/.vitepress/theme
Can you make it so a single var var(--ctp-accent)
changes those three brand colors?
Hey again :wave:, Just looking to understand where this port is at right now.
I have no idea what I'm doing so could someone please take a look at 42Willow/vitepress? I've tried to take on the feedback but I have limited experience with this stuff.
Were you able to get some help on this @42Willow?
Hi, thanks for the reminder. I just need to invest some time into finishing off this port (I have been a little busy recently)
I was thinking of theming the CSS variables directly with JS/TS (similar to how daisyui does it) rather than using whiskers for templating - what do you think about this?
I'll have some time to look into this in an hour or so
Edit: Ok I think it might be easier just to use the templated css files, I just don't know how to conditionally import them based on what's the current flavour Edit2: I figured it out but now I can't get it to work in a separate module Edit3: Check the ports discord forum, I'm stuck again
Should be ready
Theme looks good to me! We: added callout/alerts/admonition styling; added a step for setting (and set in the demo site) the markdown syntax highlighting theme to Catppuccin; added variables that themed the copy/copied clipboard icons; changed the demo site accent color to mauve; and did some documentation glow-ups!
Link to repository
https://github.com/42willow/vitepress
Screenshots
Any additional comments?
No response
Submission Guidelines