search

catppuccin / catppuccin

😸 Soothing pastel theme for the high-spirited!
https://catppuccin.com
MIT License
14.54k stars 263 forks source link

Quarto #2471

Open cadojo opened 1 month ago

cadojo commented 1 month ago

Link to repository

https://github.com/cadojo/catppuccin

Screenshots

Screenshot 2024-07-15 at 10 47 19 PM Screenshot 2024-07-15 at 10 47 23 PM

Any additional comments?

This project simply adapts pre-written Quarto website theme files with the Catppuccin themes! I have included an unofficial OLED theme too, since I see similar OLED themes in other ports. If this proposal is accepted, would it be possible to keep the directory structure I have, instead of using the template?

Submission Guidelines

lokesh-krishna commented 1 month ago

Which Quarto theme are you using in this screenshot here?

cadojo commented 1 month ago

Those screenshots are a quarto website, published as HTML, with the "theme" set to "latte.scss" and "oled.scss" in the repository I have linked.

sgoudham commented 1 month ago

Hey :wave:, thank you for submitting your work!

A few things about the repository:

  1. I understand that you'd like to keep the directory structure but I can't see a good reason for this to be the case? I'm not so interested in accepting a new port if it isn't based on the catppuccin/template repository so please update the repository to follow the template.

  2. I see that you've included the unofficial OLED theme in this repository. A decision was made a long time ago to keep our ports strictly to the official flavours specified in the v0.2.0 palette, and of course we didn't want to go back and remove the already existing OLED themes for those ports you may have seen.

    You're more than welcome to maintain and OLED version personally but for this submission to be accepted, please remove the OLED version from the repository.

  3. Instead of redefining the hex codes for each .scss file, are you able to utilise our SASS or CSS implementations? This would avoid the need for you to redefine the Catppuccin hex codes and increase the maintainability of the port!

Happy to take a look at the theme if you're still interested after my comments about the repository above. I don't mind 3. at the moment but I would definitely like 1. and 2. to be resolved.