search

catppuccin / delta

➕ Soothing pastel theme for delta
MIT License
55 stars 1 forks source link

`delta --list-syntax-themes` shows Catppuccin Latte as a dark theme #7

Closed injust closed 4 months ago

injust commented 5 months ago

I can't get Catppuccin Latte to work properly as a light theme. delta --list-syntax-themes shows it as a dark theme.

I thought that https://github.com/catppuccin/delta/pull/6 would fix this, but apparently not.

injust commented 4 months ago

The culprit seems to be https://github.com/dandavison/delta/blob/0.17.0/src/options/theme.rs#L48. delta has a hardcoded list of themes that are considered light-mode.

The value there should be catppuccin-latte (all lowercase) instead of Catppuccin-latte.

injust commented 4 months ago

Will be fixed by https://github.com/dandavison/delta/pull/1745

injust commented 4 months ago

Side note: This probably wasn't a typo actually. The casing was changed at some point after https://github.com/dandavison/delta/pull/1573 was opened but before the first commit in this repo.

elbaro commented 3 months ago 
Dark syntax themes:
    1337
    Catppuccin Latte
    Coldark-Cold

This is not fixed in delta 0.18

injust commented 3 months ago

Hmm, I think I made a bad PR. Should've changed it to Catppuccin Latte, not catppuccin-latte.

injust commented 3 months ago

https://github.com/dandavison/delta/pull/1823