search

catppuccin / fleet

🌊 Soothing pastel theme for JetBrains Fleet
https://plugins.jetbrains.com/plugin/25081-catppuccin-fleet-theme
MIT License
111 stars 2 forks source link

refactor: create plugin from SDK & publish to JB Marketplace #24

Closed davfsa closed 3 months ago

davfsa commented 3 months ago

Closes #23

davfsa commented 3 months ago

README.md will also have to be updated to point to downloading the plugin instead of copying the theme files

davfsa commented 3 months ago

And another note, .gitattributes needs to be updated too

sgoudham commented 3 months ago

I'm pretty sure we can't further test these workflows without them being present in the main branch. It's failing on retrieving the secrets and I think it's because the workflow needs to exist in the default branch first (otherwise someone could PR a new workflow into your repo and define a new step to leak your secrets, not to mention that forks don't have access to secrets)

With regards to the README update, I'd be interested in seeing if any README data gets uploaded to the marketplace since I'm not seeing in the configuration. I feel like it's fine to do the first publish and then update the README afterwards once we have the marketplace plugin URL?

Also since I don't see the gradle changelog plugin being used, are you opposed to using release-please in this repository? I'd quite like to since we use it in other repositories and it makes managing releases quite nice in a team environment, although it does have a bit of a learning curve. @davfsa

davfsa commented 3 months ago

First of all, thanks for the work on this!

Never used release-please, I'm more of a towncrier guy, but I'm welcome to learn and work with new tooling!

As for the README, I would be fine making a test release and then adapting based on that :)

And yeah, secrets can only be fetched from workflows running in the context of the repository the secrets are in (in this case, a PR wouldn't be it). If you want, I can add the secret to my fork and then I believe it would work then.

Feel free to merge when you think it's ready and we can create a test release :D

davfsa commented 3 months ago

Additional note, if we need the token to try and test build, I think it might be better to hardcode the vendor ID as part of the workflow (as I dont think its sensitive information).

Secrets will not be able to be fetched by a workflow running in the context of a PR