catppuccin / fzf

🧨 Soothing pastel theme for fzf
MIT License
157 stars 3 forks source link

Pointer and marker should probably be different colors #11

Open injust opened 6 days ago

injust commented 6 days ago

With the default fzf colors, both pointer and marker are red, but the marker is a lighter shade. This makes them easy to differentiate

The Catppuccin theme makes them both the exact same color (e.g. #f5e0dc in Catppuccin Mocha), which is not so great because the pointer and marker appear beside each other in the TUI.

In fzf 0.53.0, the default pointer and marker characters were changed to Unicode bar characters, which makes the problem worse (the default pointer character used to be >).

To demonstrate a more extreme example, I set both pointer and marker characters to the same Unicode bar character.

Screenshot 2024-06-26 at 8 34 58 AM Screenshot 2024-06-26 at 8 35 41 AM
injust commented 6 days ago

Testing some different colors for the marker with Catppuccin Mocha:

Replacing Rosewater (#f5e0dc) with Lavender (#b4befe):

Screenshot 2024-06-26 at 9 08 58 AM

Doesn't feel like the contrast is enough

Replacing Rosewater (#f5e0dc) with Blue (#89b4fa):

Screenshot 2024-06-26 at 9 07 56 AM

Definitely better now