catppuccin / github-file-explorer-icons

🐙 Soothing pastel icons for GitHub File Explorer
https://chromewebstore.google.com/detail/catppuccin-for-github-fil/lnjaiaapbakfhlbjenjkhffcdpoompki
MIT License
38 stars 1 forks source link

No longer working on main directory listing component #70

Closed peterlobster closed 3 weeks ago

peterlobster commented 3 weeks ago

Is there an existing issue for this?

Are you on the latest version of the extension?

What browser are you using?

Microsoft Edge, Google Chrome, Firefox

What issue are you experiencing?

The icons no longer work on the main page of repos on GitHub. However, it seems to work elsewhere.

image

image

uncenter commented 3 weeks ago

Thanks! Also just started seeing this. Would you like to give a try at fixing this? Would involve updating these selectors: https://github.com/catppuccin/github-file-explorer-icons/blob/62afc324c55fa0497b1af6f9162e7e6525eac2d3/src/constants.ts#L1-L20

I'll be able to fix this in a few hours either way though :)

peterlobster commented 2 weeks ago

@uncenter Awesome. Thank you. I can still try it out if you'd like. They're still not working; perphaps I need to update or wait for the release.

uncenter commented 2 weeks ago

Are you sure the extension is enabled? 0.7.0 added support for icons on new domains, which requires you to approve the new permissions for those domains - sometimes the popup doesn't appear, so you'll need to go into your extension settings and turn the extension back on.

peterlobster commented 2 weeks ago

@uncenter Ah, yes, I have an older version. Perhaps because I installed it from the Edge Store instead of the Chrome Store.

image

peterlobster commented 2 weeks ago

@uncenter I uninstalled it, and installed the Chrome Web Store version and it works just fine. Thank you!

uncenter commented 2 weeks ago

Ah yeah I couldn't tell what browser you were using from your original issue, you are correct! The Edge version was out of date since we didn't have automated publishing set up correctly. The newest 0.7.1 is properly published on all stores now, so if it makes it any easier you can switch back to that version (maybe in a few hours once it goes through the manual review process).

peterlobster commented 2 weeks ago

@uncenter Many thanks!