search

catppuccin / github

🐈‍⬛ Soothing pastel theme for GitHub
MIT License
251 stars 21 forks source link

Legibility issues in diffs #27

Closed jeffijoe closed 2 years ago

jeffijoe commented 2 years ago

Loving this theme, nice work! 🔥

Not sure if this is the right place to report this, but I ran into this while reviewing a PR. Notice how the content of the highlighted selection is difficult to read (the 7d).

image
unseen-ninja commented 2 years ago

Nice to hear you enjoy the theme; and no worries, this is the perfect place to report this. ^—^ I'm actually not quite sure what the best way to fix this would be tho.. but I'll look into it. Thanks for letting me/us know.

jeffijoe commented 2 years ago

Implementation-wise I am not sure either, but I think perhaps changing this particular instance to Base seems to help a bit:

image
unseen-ninja commented 2 years ago

It still doesn't seem to hit any contrast checks. It is better for sure, but still hard to make out on a quick glance.. tho still better than nothing. :D

unseen-ninja commented 2 years ago

Okay, so I have this very serious pull request to try and figure out a solution. The issue is, that I don't even run into the same problem you run into. D:

jeffijoe commented 2 years ago

Did you highlight (with the cursor) the 7d, or was the 7d the exact range that changed in your diff? My screenshot is for the latter.

EDIT: I just took a look at the super duper serious PR, and if you add another commit that changes 7d to 2m, you should see what I am seeing

unseen-ninja commented 2 years ago

Oh! My bad, I read that as a regular selection. This now captures the issue. Thanks again. :3

unseen-ninja commented 2 years ago

@jeffijoe heya! I think I found a way that fixes this without breaking on the dark themes. Feel free to give it a test drive and let me know what you think. c:

Screenshot 2022-09-16 at 13 29 44
jeffijoe commented 2 years ago

That looks great! Ship it! :shipit:

jeffijoe commented 2 years ago

Completely random, but I just noticed this too 😂 The @andreasgrafen (mention) highlighting looks a bit weird on the light theme 😅

image

EDIT: And here are some more, this is the GH Actions UI:

image
unseen-ninja commented 2 years ago

I'll merge the changes into main in a bit. As for the other things - the Actions def. need fixing. I'd suggest opening a new Issue to track that, but I can also do that once I'm on the train. The Github mobile app is just ... built different. xd

unseen-ninja commented 2 years ago

closed as per #29. c: