fix(status_bar): correctly apply latte colours

catppuccin / gtk

🪟 Soothing pastel theme for GTK3/4

GNU General Public License v3.0

913 stars 55 forks source link

fix(status_bar): correctly apply latte colours #166

Closed ken-kuro closed 7 months ago

ken-kuro commented 7 months ago

The change you've made in https://github.com/catppuccin/gtk/commit/355e12387f73b27cf4734a6a3eb431554fabb74f has a small bug relate to the flavor name hardcode part. I believe the key that you want to compare to the hard code string is identifier instead of name (https://github.com/catppuccin/python/blob/main/catppuccin/palette.py), however imo, we shouldn't hardcode it, so I make a simple change there.

This commit will fix some pallete mismatch on current latte variant. Before: Screenshot from 2024-04-08 10-41-40 After:

denisstrizhkin commented 7 months ago

Is this maybe related to #168?

ken-kuro commented 7 months ago

Is this maybe related to #168?

Yes it's. You can see my comparison above

t0msk commented 7 months ago

when it will be merged?

ken-kuro commented 7 months ago

This repo is currently looking for new maintainers since the current maintainers have been busy lately. So I guess we should wait until they have time, or you can become one if you have experience in maintaining and working with a GTK theme. In the meantime, you could try out my forked repo to see if the problem is fixed for you, if not, please let me know so I can update my PR.