search

catppuccin / gtk

🪟 Soothing pastel theme for GTK3/4
GNU General Public License v3.0
913 stars 54 forks source link

docs: update readme to support new build system #183

Closed ghost closed 6 months ago

ghost commented 6 months ago

this PR improves and fixes the readme for the new build system

uncenter commented 6 months ago

Also ideally the PR title should be using the conventional commits style.

ghost commented 6 months ago

@uncenter @isabelroses i added the code that you guys asked for

ghost commented 6 months ago

Also ideally the PR title should be using the conventional commits style.

maybe

nullishamy commented 6 months ago

Also ideally the PR title should be using the conventional commits style.

We can fix this at merge time, no big deal. This is going to get squashed anyways.

ghost commented 6 months ago

@nullishamy @uncenter @isabelroses i fixed the issues

uncenter commented 6 months ago

@nullishamy @uncenter @isabelroses i fixed the issues

Instead of re-pinging us there is a button under the "Reviewers" tab on the right panel that lets you re-request a review.

ghost commented 6 months ago

@nullishamy @uncenter @isabelroses i fixed the issues

Instead of re-pinging us there is a button under the "Reviewers" tab on the right panel that lets you re-request a review.

oh yeah i forgot about that

ghost commented 6 months ago

This needs merged after #178, so lets wait for that. Otherwise LGTM.

alright

nullishamy commented 6 months ago

Freezing this PR, no more changes are to be made. We will rework the README further once we release the new major. Subsequent change requests will be ignored.

ghost commented 6 months ago

Freezing this PR, no more changes are to be made. We will rework the README further once we release the new major. Subsequent change requests will be ignored.

alr