search

catppuccin / gtk

🪟 Soothing pastel theme for GTK3/4
GNU General Public License v3.0
913 stars 55 forks source link

fix: alt tab menu #209

Closed nullishamy closed 6 months ago

nullishamy commented 6 months ago

Closes #177

nullishamy commented 6 months ago

We still need to figure out what the best approach to upstreaming these patches is. Let's label it for now so we can revisit it in the future.

isabelroses commented 6 months ago

We still need to figure out what the best approach to upstreaming these patches is. Let's label it for now so we can revisit it in the future.

I think add the patch, such that anyone running the repo from main is happy. Then also upstream the patch, and remove the patch when its merged.

nullishamy commented 6 months ago

We still need to figure out what the best approach to upstreaming these patches is. Let's label it for now so we can revisit it in the future.

I think add the patch, such that anyone running the repo from main is happy. Then also upstream the patch, and remove the patch when its merged.

Was my general idea also :+1:, let's go with that. Should we make a secondary issue to track the upstream contribution? I don't think we should block our patch PRs on someone contributing it upstream?

isabelroses commented 6 months ago

Should we make a secondary issue to track the upstream contribution?

Seems like a good idea to me.

I don't think we should block our patch PRs on someone contributing it upstream?

I assume this means anyone can contribute here or upstream? If so, we should mark PRs that are considered upstream patches and send it up ourselves, that should prevent us blocking PRs to this repo.

nullishamy commented 6 months ago

I assume this means anyone can contribute here or upstream? If so, we should mark PRs that are considered upstream patches and send it up ourselves, that should prevent us blocking PRs to this repo.

I don't see why not! If we have the patch files, anyone can submit the PR upstream. Should make some labels to describe this, and have some instructions in the CONTRIBUTING?

isabelroses commented 6 months ago

I assume this means anyone can contribute here or upstream? If so, we should mark PRs that are considered upstream patches and send it up ourselves, that should prevent us blocking PRs to this repo.

I don't see why not! If we have the patch files, anyone can submit the PR upstream. Should make some labels to describe this, and have some instructions in the CONTRIBUTING?

seems good to me.

nullishamy commented 6 months ago

Blocked on v1.