catppuccin / helix

➿ Soothing pastel theme for Helix!
MIT License
164 stars 16 forks source link

Don't change color of text with diagnostics messages #17

Closed blt-r closed 1 year ago

blt-r commented 1 year ago

Currently the theme has

"diagnostic.error" = { fg = "red", underline = { color = "red", style = "curl" } }
"diagnostic.warning" = { fg = "yellow", underline = { color = "yellow", style = "curl" } }
"diagnostic.info" = { fg = "sky", underline = { color = "sky", style = "curl" } }
"diagnostic.hint" = { fg = "teal", underline = { color = "teal", style = "curl" } }

which sets foreground color of text which has diagnostics messages to the color of that message, for example:

Screenshot from 2023-01-12 17-36-05

I would argue that shouldn't be tha case, because it looks bad, that's not how it is in other Helix themes, and I don't think catppuccin does that for other editors (here is vscode for examle)

Screenshot from 2023-01-12 17-39-54 (Also I just noticed function color is different and I think vscode's is better)

The fix is very simple, just remove the fg = "..." from the code above